Skip to content

feat/aggregate-report-flagging-limitations - #1090

Merged
CJPotter10 merged 4 commits into
mainfrom
feat/dispute-aggregate-guards
Oct 30, 2026
Merged

CJPotter10 merged 4 commits into
mainfrom
feat/dispute-aggregate-guards

Conversation

@CJPotter10

Copy link
Copy Markdown
Contributor

Description

made it so that no micro reports that are also the aggregate report for that query can be used as evidence in a warning dispute and up to only 1 aggregate report can be submitted as evidence in a minor dispute. A user can still open a dispute on any micro report regardless of the dispute category or if it is an aggregate report (if you dispute an aggregate report as a minor dispute that counts as your 1 aggregate report flagged).

This should protect against someone being able to flag a bunch of aggregate reports for a lower cost

Related Issue


Fixes #

Type of Change

  • Bug fix
  • [ x ] New feature
  • Documentation update
  • State Changes (please describe)"
  • [ x ] Chain Changes (please describe): change logic for flagging aggregate reports on MsgAddEvidence
  • Daemon Changes
  • Tests
  • Added Getter

Testing

added some e2e and integration tests to verify new logic and tweaked unit tests to match new logic

Checklist

  • [ x ] Code follows project style guidelines
  • [ x ] I have added appropriate comments to my code
  • [ x ] I have updated the documentation accordingly
  • [ x ] I have added tests that prove my fix or feature works
  • [ x ] go test ./... is passing locally
  • [ x ] make e2e is passing locally

…s evidence in disputes based on dispute category
@brendaloya
brendaloya requested a review from akremstudy October 29, 2026 14:08

@akremstudy akremstudy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CJPotter10
CJPotter10 merged commit d4ff750 into main Oct 30, 2026
51 of 53 checks passed
@CJPotter10
CJPotter10 deleted the feat/dispute-aggregate-guards branch October 30, 2026 19:26
CJPotter10 added a commit that referenced this pull request Oct 30, 2026
* added limits for how many aggregate reports can be flagged and used as evidence in disputes based on dispute category

* fixed test to not tip a cyclelist query

(cherry picked from commit d4ff750)

Co-authored-by: CJPotter10 <91627020+CJPotter10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants