Skip to content

docs(Chat): improve examples to follow style guide #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

docs(Chat): improve examples to follow style guide #3236

merged 2 commits into from
Sep 17, 2025

Conversation

IvanDanchev
Copy link
Contributor

Note to external contributors: make sure to sign our Contribution License Agreement (CLA) for Blazor UI first:

https://forms.office.com/Pages/ResponsePage.aspx?id=Z2om2-DLJk2uGtBYH-A1NbWxVqugKN5DvVp8I-1AgOBURFBVSkwyMlA1TkFDVFdMNU1aM1o1UlZQOC4u

@IvanDanchev IvanDanchev requested review from a team as code owners September 15, 2025 14:35
@IvanDanchev IvanDanchev added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Sep 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Hello @IvanDanchev,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

dimodi
dimodi reviewed Sep 16, 2025
View reviewed changes
components/chat/data-binding.md Outdated
public class ChatMessage
{
public string Id { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally don't use empty lines in classes to keep the code snippets shorter.

dimodi
dimodi reviewed Sep 16, 2025
View reviewed changes
dimodi
dimodi reviewed Sep 16, 2025
View reviewed changes
dimodi
dimodi reviewed Sep 16, 2025
View reviewed changes
dimodi
dimodi approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@dimodi dimodi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ideally, code snippets should not trigger compiler warnings about possible null values. Collections should be either initialized or nullable. Component references should be nullable.
  • No need for new lines in class definitions, to make the snippets shorter.

ikoevska
ikoevska reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignored. This PR is outside of the docs-reviewers scope.

@IvanDanchev IvanDanchev merged commit 8e8105d into master Sep 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

Here you are the link to your PR to production: #3246

@github-actions github-actions bot mentioned this pull request Sep 17, 2025
Merged
@github-actions github-actions bot deleted the chat-docs-examples-enhancements branch September 17, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikoevska ikoevska ikoevska left review comments

@dimodi dimodi dimodi approved these changes

Assignees
No one assigned
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanDanchev @dimodi @ikoevska