Wrapper for isPossibleNumber & isValidNumber #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rman NDC - currently up to 03423.
…lekom/phonenumber-normalizer into method_extension/valid_number
…C up to 0711 Plus additions for 116xxx
…C up to 0999 - city are codes finished ... only need todo special codes
Update branch to catch up with current main branch
- Moving "check if original lib fixed non check of NAC..." from NormalizationTest to IsPossibleNumberWithReasonTest - improve logging in NormalizationTest & PhoneNumberOfflineGeocoderTest - Moving "check if original lib fixed isValidNumber for invalid German NDC" from IsPossibleNumberWithReasonTest into new IsValidNumberTest
Use PhoneLib 8.13.27 and prepare release
Start Snapshot 1.1.17 after release 1.1.16
|
Made a rebase on current master |
…Test: German invalid traffic routing 01981xx of mobile Emergency calls Enabled slf4j in testing
…est: German traffic routing 01982 of Emergency calls Fix slf4j warn(ing) in testing
…est: German traffic routing 01986 of public service calls
…est: German traffic routing 01987 of EU public service calls
…est: German traffic routing 01988 for international free calls
…est: German traffic routing 01989 for Call Assistant
…est: German traffic routing 0199 for internal traffic routing
…est: German personal 700 range
…est: German free call 800 range
Anrufliste
dismissed
kaikreuzer’s stale review
All Feedback is adapted into the branch
…est: German free call 900 range
…est: German test numbers 031x range
…est: German personal numbers 032 range
…est: German personal numbers 032 range - low level reserve
…est: German personal numbers 032 range - mid level reserve
…est: German personal numbers 032 range - high level reserve
…est: German explicit drama numbers
…est: German 2 digit drama number range
…est: German 3 digit drama number range
…est: invalid German NDC This is split up into 4 test, because of the 64kB Size limit when adapting them: groovyjarjarasm.asm.MethodTooLargeException The ranges are 010 - 02999; 030 - 039999; 040 - 069; 0700 - 0999
Anrufliste
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work in progress. Currently the Testcases are prepared, to check the existing two method (and the upcoming wrapper methods) against invalid German NDC.
Those are generated from the list of valid NDCs where a specific range does not use all possible variants.