Fix Readme code example and maven use #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anrufliste
force-pushed
the
fix_maven_use
branch
from
8ec8632
to
e5bb6e3
Compare
|
@kaikreuzer with the last Version Update I also introduced a new documentation https://github.com/telekom/phonenumber-normalizer/blob/main/UPDATE_FOR_NEW_PHONELIB.md and missed out to sent it to you for a prior check. So if you check the updates in this MR, it would be great, if you could also check this new document (even if in this MR only its title has been changed). Thanks and Regards, Emil |
Uses PhoneLib 8.13.20 and prepare release
Housekeeping on UPDATE_FOR_NEW_PHONELIB.md to ensure correct listing of steps.
Start Snapshot 1.1.11 after release 1.1.10
kaikreuzer
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By deploying v1.1.0 to maven central and coding an example using the jar from maven central, I discovered:
This PR fixes the bugs in the README provided examples.
It also added a fallback initialization to PhoneNumberAreaLabelImpl if no setting has been done, that the provided default data is loaded.
Finally also maven dependency stuff has been added to README.