Cloning testset from IsPossibleNumberWithReasonTest to IsValidNumberT…

…est: German VPN 018 59995 xxxx is reachable (and fix of original one)
telekom · Apr 24, 2024 · d313eb9 · d313eb9
1 parent ce53799
commit d313eb9
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/...bernormalizer/extern/libphonenumber/PhoneNumberUtil/IsPossibleNumberWithReasonTest.groovy b/...bernormalizer/extern/libphonenumber/PhoneNumberUtil/IsPossibleNumberWithReasonTest.groovy
@@ -2326,7 +2326,7 @@ class IsPossibleNumberWithReasonTest extends Specification {
         PhoneNumberUtil.ValidationResult[] expectedResults = [PhoneNumberUtil.ValidationResult.TOO_SHORT,
                                                               PhoneNumberUtil.ValidationResult.TOO_SHORT,
                                                               PhoneNumberUtil.ValidationResult.TOO_SHORT,
-                                                              PhoneNumberUtil.ValidationResult.TOO_LONG,
+                                                              PhoneNumberUtil.ValidationResult.TOO_SHORT,
                                                               PhoneNumberUtil.ValidationResult.IS_POSSIBLE,  // is reachable from normal telephony network
                                                               PhoneNumberUtil.ValidationResult.TOO_LONG,
                                                               PhoneNumberUtil.ValidationResult.TOO_LONG,

diff --git a/...ekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberUtil/IsValidNumberTest.groovy b/...ekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberUtil/IsValidNumberTest.groovy
@@ -2190,6 +2190,42 @@ class IsValidNumberTest extends Specification {
 
     }
 
+    def "check if original lib fixed isValid for German VPN 018 59995 xxxx is reachable"(String reserve, regionCode, boolean[] expectingFails) {
+        given:
+        String[] numbersToTest = [reserve + "",
+                                  reserve + "2",
+                                  reserve + "22",
+                                  reserve + "223",
+                                  reserve + "2233",
+                                  reserve + "22334",
+                                  reserve + "223344"]
+
+        Boolean[] expectedResults = [false, false, false, false, true, false, false]
+
+        when:
+        Boolean[] results = []
+        for (number in numbersToTest) {
+            def phoneNumber = phoneUtil.parse(number, regionCode)
+            results += phoneUtil.isValidNumber(phoneNumber)
+        }
+
+        then:
+        for (int i = 0; i < results.length; i++) {
+            this.logResult(results[i], expectedResults[i], expectingFails[i], numbersToTest[i], regionCode)
+        }
+
+        where:
+        reserve          | regionCode | expectingFails
+        //  018 is VPN: https://www.bundesnetzagentur.de/DE/Fachthemen/Telekommunikation/Nummerierung/018/018_Node.html
+        //  Number Plan https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/018/Nummernplan.pdf?__blob=publicationFile&v=1
+        //  Historical Reorder: https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/018/TWiderruf.pdf?__blob=publicationFile&v=1
+        //  nation number with 11 digits
+        "018 59995"      | "DE" | [false, false, false, false, false, false, false]
+        "+4918 59995"    | "FR" | [false, false, false, false, false, false, false]
+    }
+
+
+
     def "check if original lib fixed isValidNumber for invalid German NDC"(String number, regionCode, expectedResult, expectingFail) {
         given: