import annotations from future for python <3.9 #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type annotation
list[str]incomponent_data.py(l.40) is not supported under Python versions <3.9.This PR imports the required type annotation from
__future__so that it works on older Python versions also.@telegraphic - would it be possible to make a single release (1.6.4) with this fix included? I think I would suggest to explicitly drop Python < 3.9 support for future versions (I'm happy to make a separate PR for that), so that
pip install pygdsmwill resolve correctly, but it would be nice to have one last stable release that also works on older versions (currently,pip install pygdsmwill install 1.6.3 on python 3.7, which doesn't work).