Skip to content

Conversation

@telegraphic
Copy link
Owner

Merges #25 and #29.

David-McKenna and others added 11 commits April 30, 2024 16:50
I seem to have run into a case of -ffast-math optimizations differing by platform, resulting in the tests returning different values on my ARM64 laptop, vs the x86_64 runners. Increasing the elevation reduces the effective number of boundary pixels, reducing the chance of the optimizations resulting in a variable number of pixels being masked by platform.
@codecov
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.15%. Comparing base (3db1c0e) to head (bf65b01).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
pygdsm/base_observer.py 85.00% 3 Missing ⚠️
pygdsm/__init__.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   94.97%   94.15%   -0.83%     
==========================================
  Files           9        9              
  Lines         498      513      +15     
==========================================
+ Hits          473      483      +10     
- Misses         25       30       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@telegraphic telegraphic merged commit 783af2b into master Dec 21, 2024
1 of 3 checks passed
@telegraphic telegraphic deleted the dcp_test_updates branch December 21, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants