Skip to content

Conversation

@telegraphic
Copy link
Owner

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Dec 21, 2024

PR Summary

  • Improved README Documentation

    • We've enhanced the README.md file to include improved formatting and a new acknowledgment for data hosting by datacentral.org.au.
  • Streamlined Data Import and Download

    • The system can now download component data from new URLs, thanks to a function in component_data.py. This change means more consolidated and efficient management of data downloads.
  • Code Comments and Documentation

    • Documentation and comments across various modules have been enhanced to increase clarity of functionality and usage of classes and methods.
  • File Specific Updates

    • Several files have received specific updates such as gsm08.py, gsm16.py, haslam.py, lfsm.py. These changes include importing download_file utility, replacing hardcoded file paths with dynamic download solutions, readabilty enhancements, and consistent string formatting.
  • Code Clean Up and Consistency

    • Various minor formatting adjustments have been made. Additionally, unused import statements have been removed, and string formatting has been made consistent throughout the codebase.
  • Version Update

    • Updated the version number in setup.py from 1.5.4 to 1.5.5.
  • Test Enhancements

    • A new test file named test_download_data.py has been created to test the download_map_data function. Existing test scripts have been improved with dynamic file handling, consistent string formatting and assert statements.
  • General Code Improvements

    • There were efforts to enhance readability with consistent string usage, simplify error handling and variable assignments, consolidate import statements and add clarifying functionality comments. String formatting, docstring styles, and import organization have been made consistent across all files.

@codecov
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 97.68786% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.97%. Comparing base (3556c58) to head (3db1c0e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pygdsm/gsm16.py 94.44% 3 Missing ⚠️
pygdsm/base_skymodel.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   94.90%   94.97%   +0.07%     
==========================================
  Files           9        9              
  Lines         491      498       +7     
==========================================
+ Hits          466      473       +7     
  Misses         25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@telegraphic telegraphic merged commit 160146c into master Dec 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants