Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gcs): initial implementation #14

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Mar 12, 2024

I suppose this is a work in progress, since there is no tests yet. There is one todo that I left on the code. Feel free to review and/or merge this PR.

Partially closes #8

@aldy505 aldy505 added the enhancement New feature or request label Mar 12, 2024
src/gcs/gcs.ts Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (e6e14b5) to head (e4eed87).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files           4        4           
  Lines         490      490           
  Branches       85       85           
=======================================
  Hits          388      388           
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldy505 aldy505 requested a review from elianiva March 13, 2024 01:09
@elianiva elianiva merged commit 3652328 into master Mar 17, 2024
7 checks passed
@elianiva elianiva deleted the feat/gcs/initial-implementation branch March 17, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Google Cloud Storage provider
2 participants