Do not save the logs into memory using an auxiliary variable #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberm
added
bug
seberm
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
seberm
changed the base branch from
main
to
feature/enable-huge-tree-for-lxml
11 tasks
seberm
added
the
ci | full test
KwisatzHaderach
approved these changes
Nov 27, 2024
seberm
force-pushed
the
feature/enable-huge-tree-for-lxml
branch
from
21cfe4d
to
4b5bc05
Compare
seberm
force-pushed
the
feature/fix-junit-template-performance
branch
from
ec7bee0
to
ba0684a
Compare
happz
force-pushed
the
feature/enable-huge-tree-for-lxml
branch
from
cbdb31c
to
a38377b
Compare
seberm
force-pushed
the
feature/fix-junit-template-performance
branch
from
ba0684a
to
bb73e58
Compare
|
@seberm please, rebase, there will be some conflicts :/ |
Saving the **huge** test outputs into these variables causes the performance bottleneck.
seberm
force-pushed
the
feature/fix-junit-template-performance
branch
from
bb73e58
to
c1e42ec
Compare
happz
approved these changes
Nov 29, 2024
|
@seberm I'm afraid unit tests are failing. |
happz
added
the
status | ready for merge
|
Unrelated failures, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the huge test outputs into these Jinja2 variables causes the performance bottleneck.
Pull Request Checklist