Bookworm addition #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedunderwood
approved these changes
Apr 29, 2018
Owner
tedunderwood
left a comment
tedunderwood
left a comment
There was a problem hiding this comment.
Thanks! This generalization is much appreciated.
Author
|
Oh oops, you should actually roll most of this back: I thought I was pushing to a local fork of mine, not yours. There might be a piece or two you want, but most of this is just to allow a replication using a different feature set for a paper that probably doesn't make sense. |
Author
|
Sorry for the confusion! |
Owner
|
No problem. I don't think I actually merged anything. I just "reviewed the changes" and "approved them" -- but that doesn't do anything to the branch as far as I can tell! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dummy request in that I don't think you should merge it: I just wanted to ping and say hey, here's the code it takes to build a Bookworm on the type of feature data you're sharing.