Skip to content

Use Input/Output IDs instead of passing pointers through C #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CraftSpider
Copy link
Contributor

This both reduces the chance of weird soundness issues in relation to pointer provenance, and prepares the way for #1138

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 63.31658% with 73 lines in your changes missing coverage. Please review.

Project coverage is 47.06%. Comparing base (825e11b) to head (f8318ad).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
crates/bridge_core/src/lib.rs 85.18% 12 Missing ⚠️
crates/pdf_io/pdf_io/dpx-dpxfile.c 0.00% 12 Missing ⚠️
crates/pdf_io/pdf_io/dpx-tt_cmap.c 0.00% 9 Missing ⚠️
crates/pdf_io/pdf_io/dpx-dvi.c 33.33% 4 Missing ⚠️
crates/pdf_io/pdf_io/dpx-truetype.c 0.00% 4 Missing ⚠️
crates/engine_xetex/xetex/xetex-synctex.c 78.57% 3 Missing ⚠️
crates/pdf_io/pdf_io/dpx-cidtype2.c 0.00% 3 Missing ⚠️
crates/pdf_io/pdf_io/dpx-subfont.c 0.00% 3 Missing ⚠️
crates/pdf_io/pdf_io/dpx-vf.c 0.00% 3 Missing ⚠️
crates/pdf_io/pdf_io/dpx-cidtype0.c 0.00% 2 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1286      +/-   ##
==========================================
- Coverage   47.06%   47.06%   -0.01%     
==========================================
  Files         184      184              
  Lines       66302    66300       -2     
  Branches    66302    66300       -2     
==========================================
- Hits        31206    31202       -4     
- Misses      35096    35098       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CraftSpider
Copy link
Contributor Author

@Mrmaxmeier sorry to ping you again, tectonic-on-arXiv isn't appearing. If it would be helpful, is there anything I can do myself to triage/fix this kind of thing?

@Mrmaxmeier
Copy link
Contributor

@Mrmaxmeier sorry to ping you again, tectonic-on-arXiv isn't appearing. If it would be helpful, is there anything I can do myself to triage/fix this kind of thing?

No problem 🙂 Results should come in in a bit.
The machine that this was running on was retired a bit ago, so I've moved it somewhere else now. Looks like I'll need to bump up the test timeouts though since the new server is much slower. In the mean time it'll show a few "crashed" builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants