Allow multiple 'other' social links on user profile#109
Merged
Conversation
Convert socialLinks.other from a single string to a string array so users can attach multiple miscellaneous social/profile URLs. Update the updateUser and joinEventAsGuest body types and adjust the guest-join contact-method guard to treat an array of blank strings as empty. Docs (API_REFERENCE, DATABASE_SCHEMA) updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
socialLinks.otherfrom a single string to a string array so users can attach multiple miscellaneous social/profile URLs (mobile UI will iterate "Add new").updateUserandjoinEventAsGuestbody types; adjust the guest-join contact-method guard so an array of blank strings does not satisfy "at least one contact method".docs/API_REFERENCE.mdanddocs/DATABASE_SCHEMA.mdto match.No data migration needed, confirmed against the cluster that 0/67 users currently have
socialLinks.otherset.