Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move playbooks to playbooks directory to fully qualified name references (#557) #563

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ednxzu
Copy link

@ednxzu ednxzu commented Aug 9, 2024

Proposed Changes

  • This PR moves the playbooks from the root of the repository to a dedicated playbooks/ directory to follow ansible guidelines on building collections.

  • This also allows playbooks to be referenced by their fully qualified names (eg. techno_tim.k3s_ansible.site.yml) from outside the repository once the collection is installed, allowing easier integration into bigger codebases.

Checklist

  • Tested locally
  • Ran site.yml playbook
  • Ran reset.yml playbook
  • Did not add any unnecessary changes
  • Ran pre-commit install at least once before committing
  • 🚀

@timothystewart6
Copy link
Contributor

timothystewart6 commented Aug 11, 2024

The challenge is that this essentially changes how people use this in its current state. I am not sure I am ready to break the current implementation of how this works (from an end user's perspective)

https://technotim.live/posts/k3s-etcd-ansible/

@ednxzu
Copy link
Author

ednxzu commented Aug 11, 2024

I can revert the removal of the root path playbooks, so that the old way keeps working. The only change on user's end would be the path of the playbook. People don't have to use the fully qualified name to run the playbook, they can ansible-playbook -i inventory playbooks/site.yml, This simply enables the option to use fully qualified names.

@timothystewart6 timothystewart6 added the missing information Further information is requested label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing information Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants