Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check year in URLs #6886

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Check year in URLs #6886

merged 2 commits into from
Jun 7, 2024

Conversation

cgrail
Copy link
Member

@cgrail cgrail commented Jun 7, 2024

No description provided.

@cgrail cgrail merged commit 78c59d6 into main Jun 7, 2024
4 checks passed
@cgrail cgrail deleted the urlyearcheck branch June 7, 2024 14:43
@JuanPabloDiaz
Copy link
Collaborator

I like it!

You took my code, and you make it better! thank you @cgrail!!

@JuanPabloDiaz
Copy link
Collaborator

JuanPabloDiaz commented Jun 7, 2024

I was thinking on creating a separate file for those URLs that we want to allow but it's probably not necessary anymore with your fix.

// config/allowedUrls.js
module.exports = [
'https://apac.data2030summit.com', 
'https://www.ocxconf.org/event/778b82cc-6834-48a4-a58e-f883c5a7b8c9/websitePage:77320887-9b93-4211-8865-637a602eb991'
];

I saw what you did to handle this urls: https://www.ocxconf.org/event/778b82cc-6834-48a4-a58e-f883c5a7b8c9/websitePage:77320887-9b93-4211-8865-637a602eb991

but I am not sure why this url is not giving an error: https://apac.data2030summit.com @cgrail

@cgrail
Copy link
Member Author

cgrail commented Jun 8, 2024

Because I’m calculating the difference in years. If it’s more than 5 years it’s probably something different. Probably 1 or 2 years should be already enough.
https://github.com/tech-conferences/conference-data/pull/6886/files#diff-6cc51b8cf77c6faeb24cd576443066e371d0e16128e33195205ca2e28f11d990R94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants