fix(transaction): check transaction identifier #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check if transaction with identifier already exists * Return 409 conflict if transaction identifier already exists Closes: #62
There was a problem hiding this comment.
Still get an Internal Server Error when trying to init a transaction with an already existing transactionId on a different user.
Current implementation only checks that the user has no transaction with the same id associated to it, but the database has a unique constraint on the transactionId and the tenantId: t.Index(["identifier", "tenant_id"], { "unique": true })
|
How unique do we want to be with transaction ids? Should a transaction ID be unique per tenant or unique per tenant and user? |
|
I think transactionIds should be unique per tenant. |
added 2 commits
May 16, 2024 16:34
add if transaction slice is bigger than 0 Co-authored-by: Frederic Jahn <[email protected]>
FreddyDevelop
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #62