Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add privacy settings #2072

Merged
merged 1 commit into from
Mar 11, 2025
Merged

feat: add privacy settings #2072

merged 1 commit into from
Mar 11, 2025

Conversation

FreddyDevelop
Copy link
Contributor

Description

Add two privacy settings, one that disables account enumeration protection (show_account_existence_hints) and one that only returns actual configured login methods of the user (only_show_actual_login_methods).

Although otherwise discussed these two settings also have an effect when email verification is disabled. And therefore the settings are added to a privacy section in the settings.

Implementation

Added some checks that if the settings are enabled an error might be returned e.g. the account or email does not exist.

Tests

Enable and disable email, email.use_for_authentication , username, password and check that errors are returned when user already exists or does not exists and that only authentication methods are returned that the user has configures.

MFA methods are not changed because they are only already returned when they are configured by the user.

Todos

We should add a page in the docs that describes these two settings.

Add two privacy settings, one that disables account enumeration and one that only returns actual configured login methods of the user.
@FreddyDevelop FreddyDevelop merged commit 26063d3 into main Mar 11, 2025
8 checks passed
@FreddyDevelop FreddyDevelop deleted the feat-privacy-setting branch March 11, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Recently closed
Development

Successfully merging this pull request may close these issues.

2 participants