feat: add session creation endpoint #1969
Merged
+141
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we add a config parameter to enable or disable the new endpoint for security reasons? |
lfleischmann
reviewed
Nov 7, 2024
I don't think that we need a config parameter for this, because when an attacker wants to have control over an account and has access to the admin API he can just add his authentication factor (currently he can just add an email address) to the user and he can login and can remove the email address from the profile or even from the admin API. So the session endpoint only makes it easier for an attacker. |
lfleischmann
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a session creation endpoint in the admin API.