Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Flowpilot - integration #1532

Merged
merged 281 commits into from
Aug 6, 2024
Merged

Introduce Flowpilot - integration #1532

merged 281 commits into from
Aug 6, 2024

Conversation

bjoern-m
Copy link
Contributor

@bjoern-m bjoern-m commented Jul 23, 2024 •
edited
Loading

Introduce FlowPilot with Enhanced Features

Summary

This pull request introduces the new Flowpilot system along with several new features and various improvements. The key enhancements include configurable authorization, registration, and profile flows, as well as the ability to enable and disable user identifiers (e.g., email addresses and usernames) and login methods.

Key Features

  1. FlowPilot Introduction:
    • Initial setup of the Flowpilot.
    • A State history feature.
    • Hook actions for enhanced flow control.
  2. OAuth and SAML Integration:
    • Better integration with third-party services.
    • SAML flow API readiness.
    • OAuth flow API readiness.
  3. Profile and User Data Management:
    • Contextualization of the entire user model in profile flows.
    • Username management.
  4. Audit Logs and Logging:
    • Addition of audit logs for flow API actions.
  5. Configurable Attributes and Options:
    • New configuration options for login and registration flows.
  6. UI and UX Improvements:
    • Flow API support.
    • CSS adjustments for better user experience.
  7. Translation and Documentation:
    • Addition of new translations.
    • Improved documentation.

bjoern-m and others added 30 commits July 22, 2024 16:00
@bjoern-m
refactor flow api actions
19a0443
@bjoern-m
refactor: move action name constants into the related packages
76fc4b1
@bjoern-m
fix action struct name
36e8db1
@bjoern-m
refactor: rename actions, hooks, structs and files
57cf495
@bjoern-m
post-process webauthn config
b3ca375
@bjoern-m
refactor: rename a go file that belongs to the login flow
f46f76c
@bjoern-m
refactor: adds a webauthn service
a6e1530
@bjoern-m @FreddyDevelop
Update backend/flow_api/shared/services/webauthn.go
81118ab 
Co-authored-by: Frederic Jahn <[email protected]>
@lfleischmann @bjoern-m
refactor: pull passcode verification from action into service
c9b6cb8
@lfleischmann @bjoern-m
refactor: change package structure
bb3697b
@lfleischmann @bjoern-m
chore: remove commented code
df9363d
@lfleischmann @bjoern-m
refactor: rename service receivers
96dc853
@lfleischmann @bjoern-m
refactor: extract password logic into password service
6b8d5ce
@lfleischmann @bjoern-m
feat: add hook for issuing session/cookie/jwt
69b9b85
@bjoern-m
chore: passcode functionality improved
1ca6f6f
@bjoern-m
chore: small fixes
147ec48
@bjoern-m
feat: parent flow can add hooks for subflow states
61aa537
@bjoern-m
fix: hook execution corrected
c82db5c
@lfleischmann @bjoern-m
fix: skip on passkey onboarding in registration flow
32fac03 
The hook creating users is not aware of whether a user skipped
passkey onboarding. In case of a skip no credential is created
but the hook assumes there is a stringified credential avalable
on the stash. It attempts to unmarshal it but this fails.

This commit fixes it by first checking if a credential exists
on the stash.
@lfleischmann @bjoern-m
fix(flowpilot): email regex match on empty or nil input value
930bfcd 
* fix: email regex match on empty or nil input value

Input validation currently attempts a regex match on email input values
even if the input is optional but empty or nil. The match fails and
validation returns an error.

This commit fixes it by first checking if the input is optional and
whether it has an empty or nil value.

* fix: email input regex validation when input is required
@lfleischmann @bjoern-m
fix: suspend password login actions when passwords are disabled
c0ca487
@FreddyDevelop @bjoern-m
feat: add links to a flow
61332ae
@FreddyDevelop @bjoern-m
feat: generate OAuth links when provider enabled
01913e2
@FreddyDevelop @bjoern-m
fix: fix review findings
e01ef12
@FreddyDevelop @bjoern-m
chore: typos & renaming
5b6738e
@FreddyDevelop @bjoern-m
chore: typo
34cb966
@FreddyDevelop @bjoern-m
chore: make comment more clear
8b327d8
@lfleischmann @bjoern-m
fix: add missing passkey onboarding on login
59ebaab
@lfleischmann @bjoern-m
fix(flow-api): register login identifier logic
e47a900
@lfleischmann @bjoern-m
feat: add profile flow base
83b8938
lfleischmann and others added 16 commits August 2, 2024 16:15
@lfleischmann
fix: remove work in progress commands committed by mistake
2ab71f5
@lfleischmann @FreddyDevelop
fix: apply suggestions from code review
dae8f0b 
Co-authored-by: Frederic Jahn <[email protected]>
@lfleischmann
fix: explain that linking is based on email matching in allow_linking…
7627aea 
… doc
@lfleischmann
fix: make third party provider doc comments consistent
e1aff47
@lfleischmann
fix: rate limit doc comments
c7f3dc2
@lfleischmann
fix: adjust optional property comment docs
60f1f9c
@lfleischmann
chore: regenerate json schema
f5ba1f9
@lfleischmann
fix: token tests
b32120b
@lfleischmann
fix: email admin tests
e93531f
@lfleischmann
fix: email tests
6239a0d
@lfleischmann
fix: thirdparty tests
bea0452
@lfleischmann
fix: webauthn tests
a86479d
@FreddyDevelop
Change convert_legacy_config default value (#1552)
e21cb29 
* chore: change default value of convertLegacyConfig

* chore: remove double validation of config parameter

* docs: fix docs for convert_legacy_config

* chore: use new config options for docker compose
@lfleischmann
ci: update node verson in build frontend workflow
e929588
@lfleischmann
ci: use even newer node version in frontend build workflow
b3478a2
@lfleischmann
Merge branch 'main' into introduce_flowpilot_integration
77d4fa6
@lfleischmann lfleischmann marked this pull request as ready for review August 5, 2024 13:52
lfleischmann
lfleischmann previously approved these changes Aug 5, 2024
View reviewed changes
@lfleischmann lfleischmann dismissed their stale review August 5, 2024 14:03

Next JS example still not working fully.

@FreddyDevelop FreddyDevelop merged commit 601ffaa into main Aug 6, 2024
9 checks passed
@FreddyDevelop FreddyDevelop deleted the introduce_flowpilot_integration branch August 6, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreddyDevelop FreddyDevelop FreddyDevelop approved these changes

@lfleischmann lfleischmann lfleischmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
Hanko
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjoern-m @FreddyDevelop @lfleischmann