fix: don't override error before return #1447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When registering a webauthn credential fails the internal error is overridden and therefore not returned.
Implementation
The error is overridden by an auditLogger error, now the auditLog error is now assigned to a new variable instead.
Tests
Create a webauthn config where
origins
is not set correct (e.g. "https://example.com") and try to register a new webauthn credential. Before the fix the error on the logs on showcode=400, message=failed to validate attestation
. With the fix it should include the internal errorcode=400, message=failed to validate attestation, internal=Error validating origin