Add Logging on oAuth2 #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ [Feat] DTO Validation
fix bug empty files sent when onboarding & update memebr
fix: /member/me with onboarding user return 401 Unauthorized
…o feature/font-eng-name
refactor: remove terms properties in member entity
♻️ [Refactor] 폰트 이름 중복 검사 HTTP METHOD 변경
- FontServiceImpl 내 폰트 생성 및 완료 시점에 이벤트 발행 로직 추가 - FontCreateRequestNotificationEvent - FontCreateCompleteNotificationEvent - SmsService 인터페이스 및 구현체에 관련 메서드 추가 - 통합 테스트(FontServiceIntegrationTest, FontControllerIntegrationTest)에서 이벤트 및 알림 로직 검증 추가 비동기 이벤트 기반으로 알림 로직을 분리하여 서비스 응답 속도 개선 및 관심사 분리 달성
이벤트 기반 sms 알림 로직 도입 및 통합 테스트 추가
- Log errors with tempKey and fixedKey - Rethrow exception so @AfterThrowing aspect can pick it up
- Catch RestTemplate/IO errors and log warning - Prevent async exceptions from bubbling up
…scord chore: Improve S3 Event Listener and Discord Notification Error Handling
- enable Spring Retry (`@EnableRetry`) and Async processing (`@EnableAsync`) - extend `ProfileImageUpdatedEvent` to include `memberId` - implement `ProfileImageUpdateListener`: * annotate `afterCommit` with `@Async`, `@Retryable(maxAttempts=3, backoff=2000)` and `@Transactional(propagation=REQUIRES_NEW)` * log current attempt/count via `RetrySynchronizationManager` * copy S3 object from `tempKey` → `fixedKey`, delete `tempKey`, then update member’s `profileImageKey` * add `@Recover` to record permanent failures in `ProfileImageDlqRepository` and emit error logs (Discord alert TODO) * add `afterRollback` listener to clean up orphan `tempKey` on transaction rollback - create `ProfileImageDlq` JPA entity and `ProfileImageDlqRepository` for DLQ persistence - refactor `FileServiceImpl`: * remove inline member update * stage upload to S3 under `tempKey`, save metadata with `fixedKey` placeholder * publish `ProfileImageUpdatedEvent` for AFTER_COMMIT promotion * enhance logging and add method-level Javadoc - update `RegistrationController` to defer member onboarding until after file upload event - refactor `MemberUpdateService` interface to accept `memberId` instead of `Member` object - adjust unit test container to remove `MemberUpdateService` from `FileServiceImpl` builder
- Remove uploadProfileImage API and service method references - Delete ProfileImageUpdatedEvent DTO and ProfileImageUpdateListener listener - Remove uploadProfileImage/ getProfileImageUrl methods from CloudStorageService/AmazonS3BucketService - Strip out profileImageKey fields from Member domain, entity, DTOs, controllers, tests - Clean up DevTokenInitializer default profileImageKey initialization - Update integration and unit tests to remove profile image upload and URL assertions - Simplify MemberController/ProfileController/RegistrationController to no longer expect multipart file handling
chore: Add cors url
fix: remove profile image logics when login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.