chore: Improve S3 Event Listener and Discord Notification Error Handling #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Log errors with tempKey and fixedKey - Rethrow exception so @AfterThrowing aspect can pick it up
- Catch RestTemplate/IO errors and log warning - Prevent async exceptions from bubbling up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 사항
@TransactionalEventListener실행 시점을BEFORE_COMMIT→AFTER_COMMIT으로 수정하여 DB 커밋 후 S3 작업 실행S3
copyObject/deleteObject호출을try–catch로 감싸고, 에러 발생 시 로그 출력 후 예외 재던지기@Async로 실행되는 Discord 웹훅 전송을try–catch로 감싸고, 전송 실패 시 경고 로그만 남기도록 수정