Skip to content

[Fix] (classRegister times) add setValue shouldDirty option #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
constantly-dev merged 3 commits into from
Dec 30, 2025
Merged

[Fix] (classRegister times) add setValue shouldDirty option #656

constantly-dev merged 3 commits into from
Dec 30, 2025

Conversation

@constantly-dev
Copy link
Member

@constantly-dev constantly-dev commented Dec 30, 2025 •
edited
Loading

πŸ“Œ Related Issues

βœ… 체크 리슀트

  • PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”? e.g. [Feat] PR ν…œν”Œλ¦Ώ μž‘μ„±
  • λΉŒλ“œκ°€ μ„±κ³΅ν–ˆλ‚˜μš”? (pnpm build)
  • 리뷰어와 라벨을 μ§€μ •ν–ˆλ‚˜μš”?

πŸ“„ Tasks

add setValue shouldDirty option

⭐ PR Point

classRegisterμ—μ„œ times field setValueν•  λ•Œ dirty μƒνƒœ μΆ”μ ν•˜λ„λ‘ shouldDirty: true μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ“· Screenshot

2025-12-30.9.17.49.mov

πŸ”” ETC

+μΆ”κ°€λ‘œ μž₯μ†Œ λ―Έμ • checkbox도 dirty μƒνƒœ 좔적 둜직 λ„£μ—ˆμŠ΅λ‹ˆλ‹€.
클래슀 등둝/μˆ˜μ • λΆ€λΆ„ λ„ˆλ¬΄ μ½”λ“œκ°€ λ”λŸ¬μ›Œμ„œ.. 리팩 λ”°λ‘œ ν• κ²Œμš”

@github-actions github-actions bot added πŸ”§ Fix 버그 μˆ˜μ • μ§„ν˜ 이지녁 labels Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025 •
edited
Loading

βœ… Storybook 배포 μ™„λ£Œ! πŸ”— https://67e4fd1fd2c7078dceec04a4-xhulluuhhz.chromatic.com/

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 30, 2025 •
edited
Loading

Deploying dash-client-dev with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: ba9d34e
Status:Β βœ…Β  Deploy successful!
Preview URL: https://db816fcb.dash-client-dev.pages.dev
Branch Preview URL: https://fix--655-class-register-time.dash-client-dev.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 30, 2025

Deploying dash-client with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: ba9d34e
Status:Β βœ…Β  Deploy successful!
Preview URL: https://5ed4d765.dash-client.pages.dev
Branch Preview URL: https://fix--655-class-register-time.dash-client.pages.dev

View logs

heesunee
heesunee approved these changes Dec 30, 2025
View reviewed changes
Copy link
Collaborator

@heesunee heesunee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@constantly-dev constantly-dev merged commit 5555751 into develop Dec 30, 2025
8 checks passed
@constantly-dev constantly-dev deleted the fix/#655/class-register-times-dirty branch December 30, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heesunee heesunee heesunee approved these changes

@KIMGEONHWI KIMGEONHWI Awaiting requested review from KIMGEONHWI KIMGEONHWI is a code owner

@hansoojeongsj hansoojeongsj Awaiting requested review from hansoojeongsj hansoojeongsj is a code owner

@rtttr1 rtttr1 Awaiting requested review from rtttr1 rtttr1 is a code owner

Assignees

@constantly-dev constantly-dev

Labels

μ§„ν˜ 이지녁 πŸ”§ Fix 버그 μˆ˜μ •

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fix] 클래슀 μˆ˜μ • times dirty 좔적 μΆ”κ°€

3 participants

@constantly-dev @heesunee