fix: 모달 open 이후 popstate 발생시 모달 close #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KIMGEONHWI
requested review from
constantly-dev,
hansoojeongsj,
heesunee and
rtttr1
as code owners
Deploying dash-client with
|
| Latest commit: |
d90535f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a88d7324.dash-client.pages.dev |
| Branch Preview URL: | https://fix--648-spt-modal-bug.dash-client.pages.dev |
|
✅ Storybook 배포 완료! 🔗 https://67e4fd1fd2c7078dceec04a4-hxigmcqfyb.chromatic.com/ |
Deploying dash-client-dev with
|
| Latest commit: |
d90535f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fd8f6d4b.dash-client-dev.pages.dev |
| Branch Preview URL: | https://fix--648-spt-modal-bug.dash-client-dev.pages.dev |
KIMGEONHWI
added a commit
that referenced
this pull request
Dec 30, 2025
* fix: 주석 제거 (#642) * fix: 모달 open 이후 popstate 발생시 모달 close (#649) --------- Co-authored-by: hansoojeongsj <[email protected]>
constantly-dev
added a commit
to constantly-dev/35-APPJAM-WEB-DASH
that referenced
this pull request
Dec 30, 2025
* fix: 주석 제거 (team-da-sh#642) * fix: 모달 open 이후 popstate 발생시 모달 close (team-da-sh#649) --------- Co-authored-by: hansoojeongsj <[email protected]>
KIMGEONHWI
added a commit
that referenced
this pull request
Dec 30, 2025
* fix: 주석 제거 (#642) * style: profile image upload overlay color black50으로 변경 * feat: 클래스 수정 url로 접근 시에 이미 지난 기간이면 modal 띄우는 기능 추가 * fix: 모달 open 이후 popstate 발생시 모달 close (#649) * chore: 불필요한 콘솔 제거 * fix: onClose도 navigate(-1) 로직으로 수정 * chore: id valid 조건 isEditMode로 수정 * fix: popstate 이슈 해결 (#652) --------- Co-authored-by: hansoojeongsj <[email protected]> Co-authored-by: constantly-dev <[email protected]>
constantly-dev
added a commit
to constantly-dev/35-APPJAM-WEB-DASH
that referenced
this pull request
Dec 30, 2025
* fix: 주석 제거 (team-da-sh#642) * style: profile image upload overlay color black50으로 변경 * feat: 클래스 수정 url로 접근 시에 이미 지난 기간이면 modal 띄우는 기능 추가 * fix: 모달 open 이후 popstate 발생시 모달 close (team-da-sh#649) * chore: 불필요한 콘솔 제거 * fix: onClose도 navigate(-1) 로직으로 수정 * chore: id valid 조건 isEditMode로 수정 * fix: popstate 이슈 해결 (team-da-sh#652) --------- Co-authored-by: hansoojeongsj <[email protected]> Co-authored-by: constantly-dev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issues
✅ 체크 리스트
📄 Tasks
⭐ PR Point
📷 Screenshot
🔔 ETC