[Feat] class 수정 url로 접근시 비정상 접근 모달 추가 #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constantly-dev
requested review from
KIMGEONHWI,
hansoojeongsj,
heesunee and
rtttr1
as code owners
|
✅ Storybook 배포 완료! 🔗 https://67e4fd1fd2c7078dceec04a4-furzkdwecp.chromatic.com/ |
rtttr1
approved these changes
Dec 30, 2025
| const now = new Date(); | ||
|
|
||
| if (now >= startDateTime) { | ||
| console.log('비정상적인 접근입니다.'); |
hansoojeongsj
approved these changes
Dec 30, 2025
| <Modal | ||
| type="single" | ||
| content={'비정상적인 접근입니다.'} | ||
| onClose={close} |
Member
There was a problem hiding this comment.
비정상 접근 모달이 떴을 때, 모달 뒤 배경 클릭 시 모달이 그냥 닫힐 것 같은데 괜찮을지 확인 부탁드립니다 !!
Member
Author
There was a problem hiding this comment.
헉 그렇네요! onClose에 close대신 onClickHandler와 동일하게 navigate(-1) 동작으로 수정했습니다! 감사합니다~
6aae4e4
heesunee
reviewed
Dec 30, 2025
| useBlockBackWithUnsavedChanges({ methods }); | ||
|
|
||
| useEffect(() => { | ||
| if (isValidId && lessonData?.lessonRound?.lessonRounds?.length) { |
Collaborator
There was a problem hiding this comment.
id의 유효성만 확인하기 보다는 isEditMode 사용하는건 어떨까용? isEditMode = isValidId && !!lessonData일거 같은데
Member
Author
There was a problem hiding this comment.
그렇네요! 이미 isEditMode에도 valid 조건이 포함되어 있어서 isEditMode를 써도 될 것 같습니다! 수정했습니다~
92a4f74
Deploying dash-client-dev with
|
| Latest commit: |
92a4f74
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8f9ec8a8.dash-client-dev.pages.dev |
| Branch Preview URL: | https://feat--640-class-edit-url-mod.dash-client-dev.pages.dev |
Deploying dash-client with
|
| Latest commit: |
92a4f74
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3626c0ca.dash-client.pages.dev |
| Branch Preview URL: | https://feat--640-class-edit-url-mod.dash-client.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issues
✅ 체크 리스트
📄 Tasks
class 수정 url로 접근시 비정상 접근 모달 추가
⭐ PR Point
useEffect로 구현하긴 했는데 근거가 불충분 해보이거나 다른 방법이 생각나신다면 편하게 말해주세요!
추가로 한가지 문제가 건휘님이 구현해주신 작성 중 내용있을 때 이탈 방지 모달이 저기서 뜨더라고요. 아무것도 변경 안했는데도 떠서 저 비정상 접근 모달 이후에 겹쳐서 뜨는데.. 아마 그거 해결되면 여기서도 안뜰 것 같아요!
📷 Screenshot
🔔 ETC