[Refactor] SP4 모달 관련 QA 반영 #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KIMGEONHWI
requested review from
constantly-dev,
hansoojeongsj and
rtttr1
as code owners
|
✅ Storybook 배포 완료! 🔗 https://67e4fd1fd2c7078dceec04a4-rybatvpqgc.chromatic.com/ |
constantly-dev
approved these changes
Dec 22, 2025
Member
constantly-dev
left a comment
constantly-dev
left a comment
There was a problem hiding this comment.
수고하셨습니다! prod에서 한번 확인해봅시다~
Comment on lines
+82
to
+84
| requestAnimationFrame(() => { | ||
| navigate(location.pathname + location.search, { replace: true }); | ||
| }); |
Member
There was a problem hiding this comment.
코드 실행 시점을 늦추기 위해 requestAnimationFrame를 사용하신 걸까요??
Collaborator
Author
There was a problem hiding this comment.
코드 실행 시점을 늦추기 위해
requestAnimationFrame를 사용하신 걸까요??
넵, 맞습니다. 이미 모달이 열려있는 상황에서 뒤로가기시 popstate 처리 중 바로 navigate를 호출하면 방금 pushState로 되돌린 히스토리 상태가 반영되기 전에 다시 네비게이션이 일어나는 상황이 발생하였습니다. 히스토리 스택이 어긋나는 상황을 방지하기 위해서 requestAnimationFrame를 사용하였습니다!
hansoojeongsj
approved these changes
Dec 23, 2025
Member
hansoojeongsj
left a comment
hansoojeongsj
left a comment
There was a problem hiding this comment.
최공~ 정보 수정 모달에서 밖으로 나올 때, 모달을 닫으면 현재 무조건 홈으로 이동하는데 이 플로우가 맞는지 확인 부탁드립니다! 마이페이지에서 들어간 정보 수정 페이지라 닫으면 마이페이지로 돌아오는 게 자연스럽게 느껴지는 것 같습니당 ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issues
✅ 체크 리스트
📄 Tasks
⭐ PR Point
📷 Screenshot
🔔 ETC