[Fix] 아이폰 스와이프 뒤로가기 모달 중첩 이슈 해결 #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KIMGEONHWI
requested review from
constantly-dev,
hansoojeongsj,
heesunee and
rtttr1
as code owners
KIMGEONHWI
changed the title
|
✅ Storybook 배포 완료! 🔗 https://67e4fd1fd2c7078dceec04a4-bnifwjqcny.chromatic.com/ |
heesunee
approved these changes
Dec 2, 2025
Comment on lines
+92
to
+95
| onClose={() => { | ||
| isModalOpenRef.current = false; | ||
| close(); | ||
| }} |
Collaborator
There was a problem hiding this comment.
중복되는 부분이 많은것 같은데 handle~ 로 따로 뺴서 넣는거 어떨까요 ?!
constantly-dev
approved these changes
Dec 2, 2025
Member
constantly-dev
left a comment
constantly-dev
left a comment
There was a problem hiding this comment.
해당 훅은 한번 싹 리팩토링 하면 좋을 것 같아요!! 역할이 많은 느낌이어서 분리하면 좋을 것 같습니다! 수고하셨습니다~
Member
There was a problem hiding this comment.
이전에는 발견을 못했는데 맨 아래 useEffect에 있는 event.returnValue 이거 deprecated된 것 같아요!
Collaborator
Author
동의합니다! 감사합니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issues
✅ 체크 리스트
📄 Tasks
Modal 열림 상태 추적: isModalOpenRef ref를 추가해 Modal이 열려있는지 추적
중복 방지 로직 추가:
handlePopState에서Modal이 이미 열려있으면 새로운Modal을 열지 않고history.pushState만 수행.헤더 네비게이션 클릭 핸들러에도 동일한 로직을 적용했습니다.
상태 리셋: Modal이 닫힐 때 (onClose, onLeftClickHandler, onRightClickHandler) isModalOpenRef.current를 false로 리셋.
아이폰에서 스와이프로 뒤로가기할 때
popstate이벤트가 연속 발생해도Modal이 중첩되지 않습니다.Modal이 이미 열려있으면 추가로 열지 않고, 닫힌 후에만 다시 열 수 있습니다.⭐ PR Point
📷 Screenshot
🔔 ETC
cf)배포 환경에서 테스트 필요