Draft
Conversation
eito-fis
approved these changes
May 1, 2022
Collaborator
eito-fis
left a comment
eito-fis
left a comment
There was a problem hiding this comment.
Looks great! The concurrency portion w/ the runtime seems solid, and I see no issues with the queue. Only left a few small comments. Also, might be worth cleaning up the comment code in runtime and shell
| pthread_mutex_t wallet_pool_lock; | ||
| pthread_mutex_t key_pool_lock; | ||
| pthread_mutex_t mempool_lock; | ||
| int *miner_update; |
Collaborator
There was a problem hiding this comment.
Is there a reason to malloc this int?
| } | ||
|
|
||
| int shell_help(char **args) { | ||
| int shell_help(Globals *globals, char **args) { |
Collaborator
There was a problem hiding this comment.
Should (void)globals if unused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.