Fix critical bugs, add tests, CI, and improve code quality#1
Merged
Conversation
Owner
tdpham2
commented
Mar 17, 2026
- Fix MACE optimizer bug: geo_opt_cell_opt called dyn1.run() instead of dyn.run(), so cell optimization was never actually executed
- Fix shell injection vulnerability in tobacco module by replacing subprocess.call(shell=True) with safe subprocess.run([...])
- Fix missing f-string prefix in raspa2 error message
- Remove unreachable code after raise in graspa and graspa_sycl
- Replace platform-dependent sed/rm subprocess calls with Python
- Standardize os.path usage to pathlib.Path across all modules
- Add init.py with re-exports for io, mlip, orca, utils modules
- Add 42 pytest tests covering CLI, graspa, raspa3, and utils
- Add GitHub Actions CI workflow (lint, test on 3.10-3.12, build)
- Add optional dependency groups (rdkit, mlip, dev) in pyproject.toml
- Add skills.md, CHANGELOG.md, and update README with accurate docs
- Add docstrings and type hints to all public functions
- Fix type hints: steps float->int, list[int,int,int]->list[int]
- Remove unused imports across cli.py, graspa.py, raspa2.py
- Fix MACE optimizer bug: geo_opt_cell_opt called dyn1.run() instead of dyn.run(), so cell optimization was never actually executed - Fix shell injection vulnerability in tobacco module by replacing subprocess.call(shell=True) with safe subprocess.run([...]) - Fix missing f-string prefix in raspa2 error message - Remove unreachable code after raise in graspa and graspa_sycl - Replace platform-dependent sed/rm subprocess calls with Python - Standardize os.path usage to pathlib.Path across all modules - Add __init__.py with re-exports for io, mlip, orca, utils modules - Add 42 pytest tests covering CLI, graspa, raspa3, and utils - Add GitHub Actions CI workflow (lint, test on 3.10-3.12, build) - Add optional dependency groups (rdkit, mlip, dev) in pyproject.toml - Add skills.md, CHANGELOG.md, and update README with accurate docs - Add docstrings and type hints to all public functions - Fix type hints: steps float->int, list[int,int,int]->list[int] - Remove unused imports across cli.py, graspa.py, raspa2.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.