This repository has been archived by the owner on Dec 10, 2022. It is now read-only.
Eliminate potential SQL injection from database queries #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis CI updated the base images so the hacky PG 10 install is no longer needed and on top of that is failing the builds.
The TODO markers indicating the possibility of SQL injection issues were used to guide this implementation. Fixed by applying parameterized queries. Found a unitest issue that was masked by the use of concatenation in SQL and fixed the unit tests to match the runtime code execution.
Alex-Vol-SV
force-pushed
the
fix-sql-injection
branch
from
1998cde to
6fa326b
Compare
Alex-Vol-SV
commented
Dec 23, 2019
SkUrRiEr
suggested changes
Dec 28, 2019
As requested I added an actual DB query in the test. I pretty much copied the query code from the runtime to use in the test but it gets the job done.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TODO markers indicating the possibility of SQL injection issues were
used to guide this implementation. Fixed by applying parameterized
queries.
Found a unitest issue that was masked by the use of concatenation in
SQL and fixed the unit tests to match the runtime code execution.