fix: size macro key picker to device's actual macro count - #4
Merged
Conversation
KEYCODES_MACRO was hardcoded to M0-M15 regardless of what the connected board reports via keyboard.macroCount, unlike Tap Dance which is already kept in sync. Boards with fewer slots got clickable phantom macro keys with no backing storage; boards with more couldn't reach the extra slots from the quick-config picker. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyboard.macroCount, unlike Tap Dance which was already kept live.setMacroCount()inkeycodes.ts(mirrors the existingsetTapDanceCountpattern) and call it fromKeyboard.reloadMacros()right aftermacroCountis known.Test plan
pnpm buildpnpm test🤖 Generated with Claude Code