Unify encoder knob display between editor and preview - #3
Merged
Conversation
KeyboardLayoutPreview was missing the per-direction KeycapFace labels that KeyboardLayoutEditor already rendered, so unify on the editor's behavior. Also add a press icon to the knob's press row and drop its oversized font/icon overrides so all three rows (ccw/press/cw) match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeyboardLayoutPreviewwas missing the per-directionKeycapFacelabels on encoder knobs thatKeyboardLayoutEditoralready rendered (for both grouped knob widgets and loose single-direction encoders); unified on the editor's behavior.mdi:gesture-tap-button) to the knob's press row, matching the existing rotate-left/rotate-right icons.Test plan
pnpm build(tsc -b + vite build) passes