Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #386 #803

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix #386 #803

merged 1 commit into from
Jan 8, 2025

Conversation

marwiik
Copy link
Contributor

@marwiik marwiik commented Jan 7, 2025

Documentation fix to help avoid the problem described in #386. Version parameter is correctly substituted with this format; verified with manual testing.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.33%. Comparing base (92fee05) to head (ecbbcd1).
Report is 154 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #803      +/-   ##
============================================
+ Coverage     71.03%   71.33%   +0.29%     
- Complexity       96      102       +6     
============================================
  Files             7        8       +1     
  Lines           580      607      +27     
  Branches         75       79       +4     
============================================
+ Hits            412      433      +21     
- Misses          121      126       +5     
- Partials         47       48       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcurdt tcurdt merged commit 9de7d76 into tcurdt:master Jan 8, 2025
7 checks passed
@tcurdt
Copy link
Owner

tcurdt commented Jan 8, 2025

Thanks!

@marwiik marwiik deleted the issue-386 branch January 8, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants