Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes optional #801

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alerosmile
Copy link
Contributor

Closes #799

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.24%. Comparing base (92fee05) to head (626d4e1).
Report is 154 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/vafer/jdeb/DebMaker.java 26.66% 7 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #801      +/-   ##
============================================
+ Coverage     71.03%   71.24%   +0.20%     
- Complexity       96      103       +7     
============================================
  Files             7        8       +1     
  Lines           580      612      +32     
  Branches         75       81       +6     
============================================
+ Hits            412      436      +24     
- Misses          121      126       +5     
- Partials         47       50       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcurdt
Copy link
Owner

tcurdt commented Jan 7, 2025

Looking good. Thanks!

Any chance to improve the test coverage a little? It has dropped below the threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven plugin fails if changesOut is set and points to a directory which doesn't exist
3 participants