Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot version isn't expanded when <deb> is specified #386

Closed
ebourg opened this issue Oct 15, 2021 · 4 comments
Closed

Snapshot version isn't expanded when <deb> is specified #386

ebourg opened this issue Oct 15, 2021 · 4 comments
Labels

Comments

@ebourg
Copy link
Collaborator

ebourg commented Oct 15, 2021

Using the Maven plugin and jdeb 1.9, the snapshot version isn't expanded when the name of the file is overriden by specifying the <deb> element in the plugin configuration.

For example with:

          <deb>${build.directory}/foo_${version}_all.deb</deb>
          <snapshotExpand>true</snapshotExpand>

the file generated is foo_1.0-SNAPSHOT_all.deb.

@tcurdt tcurdt added the bug label Oct 18, 2021
@tcurdt tcurdt added this to the 1.11 milestone Feb 21, 2022
@tcurdt tcurdt removed this from the 1.12 milestone Mar 2, 2024
@luka-rol
Copy link

luka-rol commented Sep 13, 2024

I believe the format should be:

<deb>[[buildDir]]/[[artifactId]]_[[version]]_all.[[extension]]</deb>

/**
* Defines the pattern of the name of final artifacts. Possible
* substitutions are [[baseDir]] [[buildDir]] [[artifactId]] [[version]]
* [[extension]] and [[groupId]].
*/
@Parameter(defaultValue = "[[buildDir]]/[[artifactId]]_[[version]]_all.[[extension]]")
private String deb;

@marwiik
Copy link
Contributor

marwiik commented Jan 6, 2025

Considering @luka-rol's comment, this issue could be "fixed" by tweaking the documentation to reflect the proper format of the variables. Either way, the ${buildDirectory} variable referenced in the current docs is not resolved properly, so at least that one needs fixing.

I can submit a pull request if you think a doc update is enough.

Repository owner deleted a comment from inglepriyanka148867 Jan 6, 2025
@tcurdt
Copy link
Owner

tcurdt commented Jan 6, 2025

If this solves it, I would probably consider it just a documentation fix.

          <deb>[[buildDir]]/[[artifactId]]_[[version]]_all.[[extension]]</deb>
          <snapshotExpand>true</snapshotExpand>

marwiik added a commit to marwiik/jdeb that referenced this issue Jan 7, 2025
@marwiik marwiik mentioned this issue Jan 7, 2025
@marwiik
Copy link
Contributor

marwiik commented Jan 7, 2025

If this solves it, I would probably consider it just a documentation fix.

          <deb>[[buildDir]]/[[artifactId]]_[[version]]_all.[[extension]]</deb>
          <snapshotExpand>true</snapshotExpand>

It does, I tested it manually. I just submitted a pull request.

@tcurdt tcurdt closed this as completed in 9de7d76 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants