Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win: treat build error C3861: '_mkgmtime': identifier not found #87

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

trevorsandy
Copy link
Contributor

@trevorsandy trevorsandy commented Oct 2, 2024

Hi Travis & Peter,

I encountered this Windows build break some weeks ago and noticed that when attempting to build a clean pull of LDView master, the break is still present.

LDView_Build_C3861_Error

Cheers,

@trevorsandy trevorsandy marked this pull request as ready for review October 2, 2024 08:31
@pbartfai
Copy link
Collaborator

pbartfai commented Oct 2, 2024

I managed to build Debug Win32 code on VS2022 without this error. Which version of Visual Studio / Platform SDK do you use? I have VS2022 (17.11.4) with Windows 10 SDK (10.0.19041.0)

@trevorsandy
Copy link
Contributor Author

On VS2022 (17.11.4) I'm using Windows 11 SDK (10.0.22621.0) and Windows 10 SDK (10.0.20348.0).

For the Win32 builds, I'm also using MSVC v141 - VS 2017 and MSVC v140 - VS 2015 to support the version of the pre-compiled libraries provided with LDView.

LDView_Build_VS_Components

Cheers,

@tcobbs
Copy link
Owner

tcobbs commented Oct 3, 2024

I don't fully understand why this builds for us, but the change doesn't appear to hurt anything.

@tcobbs tcobbs merged commit c2e7409 into tcobbs:master Oct 3, 2024
5 of 6 checks passed
@trevorsandy trevorsandy deleted the C3862_Build_Error branch October 3, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants