Skip to content

Conversation

erights
Copy link
Contributor

@erights erights commented Aug 22, 2025

@ljharb
Copy link
Member

ljharb commented Aug 22, 2025

(private fields, not private symbols)

@erights erights changed the title [nonextensible-applies-to-private] Adding private symbol throws [nonextensible-applies-to-private] Adding private field to non-extensible object throws Aug 28, 2025
@erights
Copy link
Contributor Author

erights commented Aug 29, 2025

@ljharb PR title corrected.

@o- @ljharb , I tried to change the commit message to follow suit, but when I did a git push --force with the new commit message, I got

$ git push --force
ERROR: Permission to o-/test262.git denied to erights.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Outside of my patterns of habitual use, I know much less about git than I should. But I am surprised that I can have enough permission to change the PR's title and description (which I do understand is github's not git's) and not have enough permission to push.

I'll fork and redo under @erights if needed. But if could just be granted the needed permission or get advice on how else to proceed, that would be great. Thanks.

@erights
Copy link
Contributor Author

erights commented Aug 29, 2025

What does this one CI error mean?

image

@ptomato
Copy link
Contributor

ptomato commented Aug 29, 2025

@erights: re. the permission issue, you probably have the ability to change any PR or issue title throughout the TC39 organization just by virtue of being a delegate. The difference is that you don't automatically get permission to push code to someone else's personal space, which is what https://github.com/o-/test262 is. Likely @o- will have to add you as a "collaborator" which can be done in the settings.

re. the CI error, that is the ESMETA tool which executes the changed tests against the current edition of ECMAScript. It's expected to fail if you are writing a test for a stage <4 proposal.

@erights
Copy link
Contributor Author

erights commented Sep 10, 2025

Closing in favor of #4577

@erights erights closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants