Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import defer test bugs #4420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix import defer test bugs #4420

wants to merge 1 commit into from

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 12, 2025 •
edited
Loading

All the suggestions in #4416 are correct. @woess Can you confirm that this makes the tests pass? :)

Fixes #4416

@nicolo-ribaudo nicolo-ribaudo requested a review from a team as a code owner March 12, 2025 14:32
@nicolo-ribaudo nicolo-ribaudo requested a review from takikawa March 12, 2025 18:09
@woess
Copy link
Contributor

woess commented Mar 13, 2025

@nicolo-ribaudo I can confirm that this fixes the tests, and that all import-defer tests pass in my branch of GraalJS now. :)

takikawa
takikawa approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@takikawa takikawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this change makes two more tests pass on WebKit (two still fail).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takikawa takikawa takikawa approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs review test bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import defer test bugs
3 participants
@nicolo-ribaudo @woess @takikawa