Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missed parens in module-self-import-async-resolution-ticks.js #4386

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Update missed parens in module-self-import-async-resolution-ticks.js #4386

merged 1 commit into from
Jan 31, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 31, 2025

No description provided.

@Boshen Boshen requested a review from a team as a code owner January 31, 2025 05:19
ljharb
ljharb approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of hilarious how this was actually valid syntax beforehand :-p

ptomato
ptomato approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@ptomato ptomato merged commit d8e2cb2 into tc39:main Jan 31, 2025
11 checks passed
@Boshen Boshen deleted the patch-1 branch February 1, 2025 02:16
@Boshen Boshen restored the patch-1 branch February 1, 2025 02:16
@Boshen Boshen deleted the patch-1 branch February 1, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Boshen @ljharb @ptomato