Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for receiver check in IntegerIndexedElementSet #4209

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

anba
Copy link
Contributor

@anba anba commented Aug 27, 2024

Additional tests to cover some spec-compliance issues I've encountered while implementing tc39/ecma262#1556 in SpiderMonkey.

@anba anba requested a review from a team as a code owner August 27, 2024 09:02
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 27, 2024

Did you mean to push all three commits to this PR? I'm happy to approve the first one, at least, but would need to spend some more time reviewing the others.

@anba
Copy link
Contributor Author

anba commented Aug 27, 2024

Yes, that was intentional, because at least for SpiderMonkey there are shared code paths for normal property operations and environment operations, so when I've updated the property operations for out-of-bounds typed array indices, I also had to worry about environment operations. Similar story about the new test for TypedArray.prototype.set: I've also updated the TypedArraySetElement implementation in SM, which led to checking which spec operations actually call TypedArraySetElement and writing some small tests to check implementations agree on the spec semantics. This uncovered a spec violation in JSC (72933df).

@Ms2ger Ms2ger enabled auto-merge (rebase) August 27, 2024 13:21
@Ms2ger Ms2ger merged commit a444379 into tc39:main Aug 27, 2024
8 checks passed
@anba anba deleted the typed-array-oob branch August 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants