Adjust Temporal staging test of the Japanese calendar for alternative implementations #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anba
commented
May 30, 2024
anba
commented
- Move tests for before-start-of-era into a different file until there's a better specification how to handle this case → CalendarDateToISO: Constrain behaviour for regnal years? proposal-temporal#2865.
- Use helper function from Allow alternative era names #4098 to allow different era names.
ptomato
force-pushed
the
temporal-staging-japanese
branch
from
95eed5b
to
d4f8901
Compare
See also <tc39/proposal-temporal#2865> requesting for more information how this case should actually be handled.
ptomato
force-pushed
the
temporal-staging-japanese
branch
from
d4f8901
to
a4569cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.