Skip to content

Add tests for DurationFormat PR 172 and 167 #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptomato merged 1 commit into from
Jul 24, 2024
Merged

Add tests for DurationFormat PR 172 and 167 #3912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions test/intl402/DurationFormat/constructor-option-read-order.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-Intl.DurationFormat
description: Checks the order of option read.
features: [Intl.DurationFormat]
includes: [compareArray.js]
---*/

let optionKeys = Object.keys((new Intl.DurationFormat()).resolvedOptions());
let opt = {};
let readKeys = new Array();
// For each item returned by resolvedOptions of default, add a getter
// to track the reading order.
optionKeys.forEach((property) =>
Object.defineProperty(opt, property, {
get() {
readKeys[readKeys.length] = property;
return undefined;
},
}));
let p = new Intl.DurationFormat(undefined, opt);
assert.compareArray(
readKeys,
['numberingSystem',
Comment thread
ptomato marked this conversation as resolved.
'style',
'years',
'yearsDisplay',
'months',
'monthsDisplay',
'weeks',
'weeksDisplay',
'days',
'daysDisplay',
'hours',
'hoursDisplay',
'minutes',
'minutesDisplay',
'seconds',
'secondsDisplay',
'milliseconds',
'millisecondsDisplay',
'microseconds',
'microsecondsDisplay',
'nanoseconds',
'nanosecondsDisplay']);
34 changes: 34 additions & 0 deletions test/intl402/DurationFormat/prototype/resolvedOptions/return-keys-order-default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-intl.durationformat.prototype.resolvedoptions
description: order of property keys for the object returned by resolvedOptions()
features: [Intl.DurationFormat]
includes: [compareArray.js]
---*/

assert.compareArray(
Object.keys((new Intl.DurationFormat()).resolvedOptions()),
['locale',
'numberingSystem',
'style',
'years',
'yearsDisplay',
'months',
'monthsDisplay',
'weeks',
'weeksDisplay',
'days',
'daysDisplay',
'hours',
'hoursDisplay',
'minutes',
'minutesDisplay',
'seconds',
'secondsDisplay',
'milliseconds',
'millisecondsDisplay',
'microseconds',
'microsecondsDisplay',
'nanoseconds',
'nanosecondsDisplay']);
Comment thread
ptomato marked this conversation as resolved.