Scopes: Add isStackFrame/isHidden bits and make 'kind' optional #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuend
changed the title
jridgewell
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of presenting the "Scopes - missing bits" slides to TG4 and incorporating the feedback and follow-up discussion.
Specifically this PR changes the following:
OriginalScope.kindoptional. The free-form text can't really be used by consumers in algorithms that apply the scopes info to stack traces. As such it serves mostly as a user-facing label in debuggers/stack trace processors.OriginalScope.isStackFrameandGeneratedRange.isStackFrameto signify whether a scope/range corresponds to the semantic equivalent of a function call in the authored/generated language respectively. ForGeneratedRange.isStackFramewe re-use the existingGeneratedRange.isScopeflag that is not required. This change makes the open PR Scopes: Re-purposeisScopeasisFunctionScopefor stack trace processing #114 obsolete.GeneratedRange.isHiddenflag to mark outlined functions that have aGeneratedRange.definition. This allows debuggers to remove transpiler inserted functions from stack traces, while still enabling variable/values if the transpiler inserted function corresponds to actual original source code.