Next batch of editorial issues #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires tc39/test262#4220 for the tests to pass. |
Ms2ger
approved these changes
Sep 10, 2024
ptomato
force-pushed
the
editorial
branch
2 times, most recently
from
5c2afc7
to
3288957
Compare
If running this test file without first importing the proposal polyfill, it would fail due to the new intrinsics not being defined. We never noticed this because we usually run datemath.mjs before this file.
In the calendar-specific code, in isoToCalendarDate(), we should not be computing the era year if the calendar doesn't have eras.
In 'hebrew', 'chinese', and 'dangi' calendars, there are no eras. Any eraYear property given in calendar fields must be ignored, as per CalendarResolveFields in the spec text. Adjust the helpers for Hebrew and Chinese/Dangi calendars accordingly; the eraYear was being used in place of the year in some cases. Closes: #2870
This was an overzealous replacement of CalendarDateAdd with BalanceISODate spotted by Anba. It doesn't produce any observably different results, because in all supported calendars weeks are always 7 days; but it's still conceptually incorrect. Go back to using CalendarDateAdd here. Closes: #2881
Otherwise the loop would not run. Closes: #2890
As pointed out by Anba, this AO does nothing if smallestUnit equals largestUnit, not just if smallestUnit equals "year". We can simplify the early return condition. See: #2890
smallestUnit is a date unit. In the loop, unitIndex runs from the index before smallestUnit and is decremented, meaning that unit can only ever be "year", "month", or "week". Thanks to Anba for spotting this. See: #2890
Same thing, just shorter and clearer. Closes: #2923
It's not possible for the duration to not be valid here, as _duration_ is a valid duration, and the duration being tested is _duration_ truncated to days, which can only ever be less than _duration_. Spotted by Anba. Closes: #2880
…an calendars Dates in these calendars display an era when they are formatted in English using Intl.DateTimeFormat, but not when they are formatted for the region where the calendar is used. That likely indicates they shouldn't have eras. Remove `constantEra` from the calendar helpers, and introduce a new helper that calculates dates relative to a fixed year zero. Closes: #2899
As of the current state of the Intl Era and Month Codes proposal, the eras table in https://tc39.es/proposal-intl-era-monthcode/#table-eras has a canonical name for each era, and a number of aliases which should also be accepted. Legacy ICU names such as "era0" should not be accepted, although they still need to be handled when using Intl.DateTimeFormat to convert dates. Closes: #2901
The makeHelper___() functions already return a new object, so we don't
need to Object.assign() them to {}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit. Explanations in each commit message. Closes several issues opened by @anba and others.