Add CreateAsyncContextSnapshot AO
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
approved these changes
Jul 8, 2024
legendecas
reviewed
Jul 9, 2024
In the web integration of AsyncContext, web specs will need to create `AsyncContext.Snapshot` objects from an AsyncContext mapping; and we expect this to be necessary for other kinds of hosts as well, such as Node.js. Currently the spec text does not provide any way to do that other than manually creating the object and populating its `[[AsyncContextMapping]]` slot, since the `AsyncContext.Snapshot` constructor always uses the current mapping. So this patch adds an abstract operation called `CreateAsyncContextSnapshot` that provides this capability.
andreubotella
force-pushed
the
to-async-context-snapshot-object
branch
from
ef54cca to
2ed4db2
Compare
andreubotella
changed the title
ToAsyncContextSnapshotObject AOCreateAsyncContextSnapshot AO
legendecas
approved these changes
Jul 9, 2024
Qard
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the web integration of AsyncContext, web specs will need to create
AsyncContext.Snapshotobjects from an AsyncContext mapping; and we expect this to be necessary for other kinds of hosts as well, such as Node.js.Currently the spec text does not provide any way to do that other than manually creating the object and populating its
[[AsyncContextMapping]]slot, since theAsyncContext.Snapshotconstructor always uses the current mapping. So this patch adds an abstract operation calledCreateAsyncContextSnapshotthat provides this capability.