feat: Add handlebars helpers for math, arrays, and json - #408
Open
tbuckley wants to merge 2 commits into
Open
Conversation
Deploying evals-pwa with
|
| Latest commit: |
bd4c28d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccb12067.evals-pwa.pages.dev |
| Branch Preview URL: | https://handlebars-math-arrays-json.evals-pwa.pages.dev |
There was a problem hiding this comment.
Bug: Handlebars Helper Bugs: Type Errors and Name Collisions
The recent addition of Handlebars helpers introduces two issues:
- Array Helper Flaws: The
first,last,rest,length, andslicearray helpers lack runtime type checking, causing errors when used with non-array inputs (e.g., null, undefined, strings). Additionally, their TypeScript types are incorrectlystring[]instead ofany[], leading to compilation errors for non-string arrays. - Name Collisions: Many new helpers (
first,last,rest,length,slice,add,sub,mult,div,json) use common names. Due to Handlebars' helper precedence, these helpers shadow existing variables with the same names, causing breaking changes in templates that previously accessed those variables (e.g.,{{ first }}now invokes the helper).
src/lib/utils/HandlebarsPromptFormatter.ts#L34-L43
evals-pwa/src/lib/utils/HandlebarsPromptFormatter.ts
Lines 34 to 43 in bd4c28d
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.