feat: allow writing evals.json for config - #404
Open
tbuckley wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Bug: JSON Errors Misreported as YAML
When parsing JSON configuration files, errors are incorrectly reported as "Invalid YAML". The getConfig method's error handling logic is designed for YAML-specific errors, causing JSON parsing failures to fall through to a generic message that hardcodes "Invalid YAML". Consequently, JSON errors also lack detailed line-specific information.
src/lib/storage/FileSystemEvalsStorage.ts#L100-L110
evals-pwa/src/lib/storage/FileSystemEvalsStorage.ts
Lines 100 to 110 in 111a5b1
BugBot free trial expires on July 22, 2025
Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.