Make parsing Maven projects recursive, and check if the same dir cont… #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thank you for the pull request 🎉 , I'll have a look at it when I get a chance this week. |
|
Hmm I might have a think about this, it moves all the work to the first loop of the iteration, I wonder if there's another way to achieve it. I also wanted to support detecting multiple types of project in the same directory which would complicate this 🤔 |
…ains multipe projects, for example Maven and Node
gzsombor
force-pushed
the
multi-project-fix
branch
from
b35f123
to
1f20152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ains multipe projects, for example Maven and Node