Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ Awesome people who contributed to this package

- [dsentker](https://github.com/dsentker)
- [schwabwaldemar](https://github.com/schwabwaldemar)
- [haraldpdl](https://github.com/haraldpdl)

## Honorable mentions
thanks for support go to:
thanks for support goes to:
- [Robinson-Software-Development](https://github.com/robinson-software-development)
2 changes: 1 addition & 1 deletion src/CachedServiceGenerator/Dto/MethodCallObject.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function getCachePrefix(): string
return str_replace(['\\', ':', ' '], ['_', '-', ''], $this->getClass());
}

public function getCallable(): ?callable
public function getCallable(): callable
{
return fn () => call_user_func_array([$this->class, $this->method], $this->arguments);
}
Expand Down
2 changes: 1 addition & 1 deletion src/DataCollector/MultiLevelCacheDataCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

class MultiLevelCacheDataCollector extends DataCollector implements DataCollectorInterface
{
private const LOW_HITRATE_NOTICE_THRESHOLD = 9;
private const int LOW_HITRATE_NOTICE_THRESHOLD = 9;

private bool $isInitialized = false;
private bool $processedAdditionalIssues = false;
Expand Down
11 changes: 0 additions & 11 deletions src/Service/MultiLevelCacheService.php
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,6 @@ public function getBulk(
'mlcCacheableMethodAttribute' => $mlcCacheableMethodAttribute,
],
));
$this->raiseIssue(ErrorEnum::ERROR_BULK_CONFIG_MISSING, new DataCollectorIssueOccurrenceDto(
affectedCacheGroup: $this->cacheGroupName,
affectedKeys: $keys,
context: [
'methodCallObject' => $methodCallObject,
'mlcCacheableMethodAttribute' => $mlcCacheableMethodAttribute,
],
));

throw new RuntimeException('BulkConfig is required for bulk operations');
}
Expand All @@ -206,9 +198,6 @@ public function getBulk(

// do one bulk call to source for all non-cached requests and cache them individually
if (!empty($requestsToSource)) {
$sourceArguments = $methodCallObject->getArguments();
$sourceArguments[0] = $requestsToSource;
$methodCallObjectForSource = $methodCallObject->clone(arguments: $sourceArguments);
$sourceArguments = $methodCallObject->getArguments();
$sourceArguments[0] = $requestsToSource;
$methodCallObjectForSource = $methodCallObject->clone(arguments: $sourceArguments);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public function testFindRootForClassWithCorruptedNamespace(): void
{
require_once($this->testFilesRootPath . '/CorruptedNamespace.php');
$this->expectException(RuntimeException::class);
$result = FileOperationService::findRootForClass(CorruptedNamespace::class);
FileOperationService::findRootForClass(CorruptedNamespace::class);
}

private function checkFileSyntax(string $file): void
Expand Down
Loading