fix(macos): support app bundle as a framework #14319
Open
+19
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when bundling a MacOS bundle, tauri-build and tauri-bundle only accept .dylib and .Framework extensions. But there is such case where applications might need to bundle .app in the application Frameworks. See:
https://bitbucket.org/chromiumembedded/cef/wiki/Tutorial.md#markdown-header-mac-os-x-build-steps
Current behavior:
When bundling .app files in Frameworks, it will throw an error stating, "Could not locate framework: {framework}".
Expected behavior:
It should include the .app file in the Frameworks section as soon as developers define it in the tauri config JSON file.
This change merely duplicates the existing .framework logic and also accepts .app files.
Inspiration
We are developing a browser app using Tauri and CEF, a forked version of Tauri-bundle could serve as a temporary solution. However, some developers might install the official version on crates when building the application, so we would like to have this change merged upstream.